Skip to content

Conversation

@skjha98
Copy link
Contributor

@skjha98 skjha98 commented Dec 25, 2025

Description: This PR addresses several clippy::pedantic warnings related to the locale embedding logic in uucore.

Changes:

  • Added a missing # Errors section to the embed_locale_file documentation in build.rs.
  • Updated the code generator in build.rs to dynamically handle raw string literals. It now detects if the translation content contains double quotes and uses the appropriate hash delimiter (r"..." vs r#"..."#).
  • This fix resolves clippy::needless_raw_string_hashes in the generated output.

Testing: Verified by running cargo clippy -p uu_whoami -- -W clippy::pedantic and confirming the warnings related to build.rs and the generated locale code are gone.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!

@sylvestre
Copy link
Contributor

Could you please update github action to run it in the ci?

@sylvestre sylvestre merged commit d8e8803 into uutils:main Dec 25, 2025
169 of 171 checks passed
@skjha98 skjha98 deleted the fix/build-clippy-warnings branch December 25, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants