ptx: handle invalid regex arguments gracefully instead of panicking #9825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a panic in
ptxwhen an invalid regular expression is passed to the-W(--word-regexp) argument.Previously, running:
ptx -W 'bar\\\'would result in a Rust panic (
called Result::unwrap() on an Err value).This change catches the
regex::Error, wraps it in aUSimpleError, and ensures the program exits with code 1 and prints a user-friendly message to stderr.Testing
tests/by-util/test_ptx.rsto verify:bar\) return exit code 1.(wrong) return exit code 1.