ptx: handle duplicate input files #9823
Open
+25
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running
ptx file filewould only output the content of thefileonce. This caused the GNU testptx ws.in ws.in | sort | uniq -uto fail (it expects identical output twice, whichuniq -ufilters out; we were outputting once, souniq -uprinted it).Input files were stored in a
HashMapkeyed by filename. The second occurrence of the file overwrote the first.Fix
Changed the internal
FileMapstorage to aVecto preserve the order and multiplicity of input files.Tests
tests/ptx/ptx-overrun.share now passing correctly.test_duplicate_input_filesintests/by-util/test_ptx.rs.