dd: use actual filename in nocache error messages #9820
+26
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
fix-dd-nocache-error-message
branch
from
5df6c6d to
9b562ee
Compare
ChrisDryden
force-pushed
the
fix-dd-nocache-error-message
branch
from
9b562ee to
9ed9e8e
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was investigating the nocache_fail changes and it appears that the reason it is failing is actually just because the GNU implementation uses the actual name of the file instead of a hardcoded value if its not stdin or stdout. This simple change just changes the error message to take in the filename if its provided.