ptx: fix panic when reference length exceeds line width #9816
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a panic in
ptxwhere subtraction overflow occurred if the generated reference string (filename + line number) was longer than the specified line width (e.g.,ptx -w 1 -A long_file).Fix:
Changed direct subtraction
config.line_width -= max_ref_lentosaturating_sub. If the reference consumes the entire line, the available width for context simply becomes0.Tests:
Fixes failure in GNU test
tests/ptx/ptx-overrun.sh.Added new regression test
test_narrow_width_with_long_reference_no_panic.