cp: Preserve mode for directories when copying by default. #9794

nikolalukovic · 2025-12-23T14:06:54Z

Attempts to fix: #7961

github-actions · 2025-12-23T14:23:07Z

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

github-actions · 2025-12-23T15:54:34Z

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

github-actions · 2025-12-23T16:36:57Z

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

tests/uutests/src/lib/util.rs

github-actions · 2025-12-29T07:14:48Z

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

github-actions · 2025-12-31T16:09:58Z

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-12-31T18:14:36Z

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-04T14:37:29Z

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-04T15:46:00Z

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-04T16:13:33Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!

github-actions · 2026-01-04T16:43:49Z

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

nikolalukovic · 2026-01-04T16:49:38Z

This fix feels more like a human rights violation. I'll see how to streamline the checks that have to be done and do it in a more idiomatic Rust way.

github-actions · 2026-01-04T17:11:30Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!

sylvestre · 2026-01-04T18:12:35Z

the new "mut" aren't a good sign indeed ;)

github-actions · 2026-01-08T14:53:13Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-08T15:15:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-09T12:13:51Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

nikolalukovic · 2026-01-09T13:15:08Z

@sylvestre ready for review

src/uucore/src/lib/features/fs.rs

nikolalukovic · 2026-01-12T18:20:35Z

@sylvestre ready for review

sylvestre · 2026-01-13T06:59:55Z

src/uu/cp/src/cp.rs

    source: &Path,
    dest: &Path,
    attributes: &Attributes,
+    is_dest_created: bool,


in copydirs, you still have a call to this function with 3 parameters

sylvestre · 2026-01-13T07:00:46Z

src/uu/cp/src/cp.rs

+            let perms = source_metadata.permissions();
+            #[cfg(unix)]
+            {
+                let mut perms = source_metadata.permissions();


you are replacing the previous let perms immediately
please refactor to avoid this
thanks

github-actions · 2026-01-13T08:35:21Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-13T09:04:32Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

… needed changes for the added test

nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from e5a0699 to e96a0d6 Compare December 23, 2025 14:21

nikolalukovic force-pushed the fix/7961 branch from e96a0d6 to 14b10ae Compare December 23, 2025 15:37

nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from aa40f09 to de4e3ec Compare December 23, 2025 16:19

nikolalukovic marked this pull request as draft December 23, 2025 20:41

sylvestre reviewed Dec 23, 2025

View reviewed changes

tests/uutests/src/lib/util.rs Outdated Show resolved Hide resolved

nikolalukovic force-pushed the fix/7961 branch from de4e3ec to 6143aef Compare December 28, 2025 20:09

nikolalukovic force-pushed the fix/7961 branch from 83c9df8 to e64a4ce Compare December 31, 2025 15:57

nikolalukovic force-pushed the fix/7961 branch from e64a4ce to 8e9b3d9 Compare December 31, 2025 17:59

nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from f782887 to 3eb23ee Compare January 4, 2026 14:27

nikolalukovic force-pushed the fix/7961 branch from 3eb23ee to b31ffda Compare January 4, 2026 15:30

nikolalukovic force-pushed the fix/7961 branch from 51b3597 to ba86156 Compare January 4, 2026 16:09

nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from 7d33c02 to bd35186 Compare January 4, 2026 16:39

nikolalukovic force-pushed the fix/7961 branch from bd35186 to f617d12 Compare January 4, 2026 18:07

nikolalukovic force-pushed the fix/7961 branch from 6aad24c to b04ed86 Compare January 8, 2026 14:39

nikolalukovic marked this pull request as ready for review January 8, 2026 16:13

nikolalukovic force-pushed the fix/7961 branch 3 times, most recently from 9f17ad4 to 0be3ca6 Compare January 9, 2026 11:05

sylvestre reviewed Jan 9, 2026

View reviewed changes

src/uucore/src/lib/features/fs.rs Show resolved Hide resolved

nikolalukovic force-pushed the fix/7961 branch from 0be3ca6 to 9ce6794 Compare January 9, 2026 14:51

nikolalukovic requested a review from sylvestre January 9, 2026 16:07

sylvestre reviewed Jan 13, 2026

View reviewed changes

nikolalukovic force-pushed the fix/7961 branch from 03ee6de to 3d2f84c Compare January 13, 2026 08:22

nikolalukovic force-pushed the fix/7961 branch from e0ab439 to 28cef74 Compare January 13, 2026 08:46

nikolalukovic added 10 commits January 15, 2026 08:18

cp: Preserve mode for directories when copying by default.

be54633

cp: Move get_mode util func to test_cp

e3a986f

cp: Added additional gnu test which *has* to work in combination with…

e4f56b2

… needed changes for the added test

cp: Fix default preserve when creating directories

a722e85

cp: Fix explicit preserve mode

2f90ba9

cp: Test modification specifically for Android

9bde23e

cp: Remove unneeded check

66ca85f

cp: Remove unnecessary variable shadowing

4da3c75

cp: rebase to newest main and fix copy_attributes call

7230a3a

cp: allow needed mut for platforms other than unix

53ec3df

nikolalukovic force-pushed the fix/7961 branch from 28cef74 to 53ec3df Compare January 15, 2026 07:18

Uh oh!

cp: Preserve mode for directories when copying by default. #9794

Are you sure you want to change the base?

cp: Preserve mode for directories when copying by default. #9794

Uh oh!

Conversation

nikolalukovic commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

nikolalukovic commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

sylvestre commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

nikolalukovic commented Jan 9, 2026

Uh oh!

Uh oh!

nikolalukovic commented Jan 12, 2026

Uh oh!

sylvestre Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants