env: fix regression of --ignore-signal=PIPE
#9618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
c362cfb to
62e4f7b
Compare
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
62e4f7b to
67a4741
Compare
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
67a4741 to
8a264a0
Compare
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
8a264a0 to
73a0844
Compare
|
GNU testsuite comparison: |
Contributor
|
please fix the conflicts |
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
73a0844 to
98e348d
Compare
Collaborator
Author
I have fixed the conflicts. However while doing it I have noticed that the test fails if the default "yes" is from uutils coreutils on the machine running the test (it works with "yes" from GNU coreutils). This is because uutils yes unconditionally restores the sigpipe handler to its default value (by calling I could fix it in this PR as well, but it is not directly related in principle. |
|
GNU testsuite comparison: |
- revert uutils#9614 because `Command::exec()` resets the default signal handler for SIGPIPE, interfering with the option `--ignore-signal=PIPE` - add regression-test for --ignore-signal=PIPE - add FIXME comment about execvp() Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Ecordonnier
force-pushed
the
eco/env/execvp
branch
from
98e348d to
cffd508
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command::exec()resets the default signal handler for SIGPIPE, interfering with the option--ignore-signal=PIPEFixes #9617