sort: Introduce locale-aware month sorting #8421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Aug 5, 2025
|
|
||
| match response.payload.get() { | ||
| MonthNames::Linear(months) => Some(months.iter().map(ToString::to_string).collect()), | ||
| _ => todo!("unsupported"), |
Contributor
There was a problem hiding this comment.
please add a comment detailing what should happen here
sylvestre
reviewed
Aug 5, 2025
| } | ||
|
|
||
| pub fn locale_abbr_month_names() -> Option<&'static [String]> { | ||
| static DECIMAL_SEP: OnceLock<Option<Vec<String>>> = OnceLock::new(); |
Contributor
There was a problem hiding this comment.
sorry but what means DECIMAL_SEP in this context?
sylvestre
reviewed
Aug 5, 2025
| # to the abbreviated month of april in the French locale: | ||
| # GNU is 'avril' | ||
| # ICU is 'avr.' | ||
| # sed -i -e 's|\(LC_ALL=$LOC locale abmon 2>/dev/null\)|\1 \| sed s/avril/avr./|' tests/sort/sort-month.sh |
Contributor
|
@RenjiSann do you have an update on this ? merci :) |
Collaborator
Author
Hi, I don't have much time recently to work on it. And I probably won't have the time for another few weeks or so. Anyway, if someone wants to keep on going with this before I can finish, feel free to do so :) |
Contributor
|
please reopen when ready! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for locale-aware month-sorting.