Skip to content

publish.sh: be more prescriptive on the grep #7983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 1 commit into from
May 25, 2025
Merged

publish.sh: be more prescriptive on the grep #7983

cakebaker merged 1 commit into from
May 25, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented May 25, 2025

otherwise, we are getting version.workspace first

@sylvestre
publish.sh: be more prescrive on the grep
a7a9e07 
otherwise, we are getting version.workspace first
@github-actions
Copy link

github-actions bot commented May 25, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed May 25, 2025
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. An alternative would be to move the workspace.package section to the top of Cargo.toml instead.

There is an unknown word in the commit message (and PR title): prescrive. Did you mean "precise"?

@sylvestre
Copy link
Contributor Author

sylvestre commented May 25, 2025

it meant "prescriptive" sorry!

@cakebaker cakebaker merged commit 2f577a7 into main May 25, 2025
147 checks passed
@cakebaker cakebaker deleted the sylvestre-patch-1 branch May 25, 2025 14:33
@cakebaker cakebaker changed the title publish.sh: be more prescrive on the grep publish.sh: be more prescriptive on the grep May 25, 2025
sylvestre added a commit to sylvestre/coreutils that referenced this pull request Jun 2, 2025
@sylvestre
publish.sh: be more prescriptive on the grep (uutils#7983)
5761fef 
otherwise, we are getting version.workspace first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sylvestre @cakebaker