uucore/buf_copy: bug fixes for compatibility with uutils core utilities #6983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaringCuteSeal
force-pushed
the
uucore-splice-cross
branch
from
d76f030 to
542f6c6
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 20, 2024
| use crate::error::UError; | ||
| use std::io::{Read, Write}; | ||
|
|
||
| #[cfg(any(target_os = "linux", target_os = "android"))] |
Contributor
There was a problem hiding this comment.
it is starting to look messy with all the cfg
maybe the .rs file per platform ?
for example:
src/uu/tail/src/platform/
sylvestre
requested changes
Dec 22, 2024
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
needs some refactoring. Too many cfg
Contributor
Author
|
oh right on that, wait |
DaringCuteSeal
force-pushed
the
uucore-splice-cross
branch
2 times, most recently
from
791c24c to
0b793ef
Compare
Contributor
Author
|
@sylvestre how's it |
sylvestre
reviewed
Dec 28, 2024
sylvestre
reviewed
Dec 28, 2024
sylvestre
reviewed
Dec 28, 2024
| @@ -0,0 +1,29 @@ | |||
| use crate::error::UError; | |||
Contributor
There was a problem hiding this comment.
please add the license header here
the splice_data_to_fd function now does not loop forever and returns the amount of bytes written properly.
several tests now are executed properly with proper handling of pipelines.
refactor the buf_copy module into Linux and non-Linux implementations.
sylvestre
force-pushed
the
uucore-splice-cross
branch
from
0b793ef to
148c531
Compare
Contributor
|
much better, thanks :) |
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
DaringCuteSeal
force-pushed
the
uucore-splice-cross
branch
from
20baf32 to
028293c
Compare
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
DaringCuteSeal
force-pushed
the
uucore-splice-cross
branch
from
028293c to
c2f3a76
Compare
Contributor
Author
|
there, should be ok now |
|
GNU testsuite comparison: |
Contributor
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues that previously hindered the usage of the new buffer-based copying module (#6964) in several core utilities (notably
cp,cat,yes, andinstall).