Improve "stat" compatibility #6933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
Regressed this test. I will have a look later. |
and other formats should fix tests/stat/stat-fmt.sh
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
cakebaker
reviewed
Dec 8, 2024
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 9, 2024
cakebaker
reviewed
Dec 9, 2024
cakebaker
reviewed
Dec 9, 2024
cakebaker
reviewed
Dec 9, 2024
Comment on lines
+333
to
+334
| display_name: &str, | ||
| file: &OsString, |
Contributor
There was a problem hiding this comment.
Is display_name necessary? It looks to me like you could get it from file with file.to_string_lossy().
Contributor
Author
There was a problem hiding this comment.
it seems legit but it isn't:
https://github.com/uutils/coreutils/blob/main/src/uu/stat/src/stat.rs#L639-L640
as you can see here, we are keeping the original name and changing :)
cakebaker
reviewed
Dec 9, 2024
cakebaker
reviewed
Dec 9, 2024
|
GNU testsuite comparison: |
Contributor
Cool, two tests fixed with one PR, good job :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.