kill: replace nix::sys::signal with rustix::process#12326
Open
mattsu2020 wants to merge 2 commits into
Open
Conversation
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix::sys::signalusage in thekillutility withrustix::processAPIs as part of the migration away from nix (see chore(deps): update rust crate clap to v4.5.30 #7317)kill_processfor positive PIDskill_process_groupfor negative PIDskill_current_process_groupfor PID0test_kill_*variants for signal0libc::killpath for libc realtime signals (SIGRTMIN..=SIGRTMAXon Linux/Android), because rustix'sSignalcontract does not allow libc-reserved realtime signal values to be used for sending signalsi32::MINoverflow withchecked_neg()when negating negative PIDsPid::from_raw()withexpect()instead ofPid::from_raw_uncheckedTests
cargo build -p uu_killcargo test -p coreutils --test tests --features kill -- test_kill_(37 passed on macOS)Note: the realtime signal send test is Linux/Android-only and is therefore not run on macOS.