Skip to content

tee: rename ErrorKind::Other to its usage#12314

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-cleanup
Open

tee: rename ErrorKind::Other to its usage#12314
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-cleanup

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 15, 2026

No description provided.

@sylvestre
Copy link
Copy Markdown
Contributor

sorry but i don't understand the point of this PR ?!

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 15, 2026

I wanted to concentrate comment about hacky usage of ErrorKind::Other.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review May 15, 2026 14:13
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:tee-cleanup (0206006) with main (aaf4a35)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 23, 2026

Would you review this? There are 3 commens describing same hacky usage of ErrorKind::Other which is verbose.

@oech3 oech3 changed the title tee: reduce lines of code tee: rename ErrorKind::Other to its usage May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants