Skip to content

uutests: add LICENSE#11356

Open
michel-slm wants to merge 1 commit intouutils:mainfrom
michel-slm:uutests-add-license
Open

uutests: add LICENSE#11356
michel-slm wants to merge 1 commit intouutils:mainfrom
michel-slm:uutests-add-license

Conversation

@michel-slm
Copy link
Contributor

Symlink LICENSE from the project root so it gets picked up when packaging

coreutils/tests/uutests on uutests-add-license
$ cargo package --allow-dirty --list | grep LICENSE

coreutils/tests/uutests on uutests-add-license
$ ln -s ../../LICENSE .

coreutils/tests/uutests on uutests-add-license
$ cargo package --allow-dirty --list | grep LICENSE
LICENSE

Symlink LICENSE from the project root so it gets picked up when packaging

```
coreutils/tests/uutests on uutests-add-license
$ cargo package --allow-dirty --list | grep LICENSE

coreutils/tests/uutests on uutests-add-license
$ ln -s ../../LICENSE .

coreutils/tests/uutests on uutests-add-license
$ cargo package --allow-dirty --list | grep LICENSE
LICENSE
```

Signed-off-by: Michel Lind <salimma@fedoraproject.org>
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!

@oech3
Copy link
Contributor

oech3 commented Mar 17, 2026

I s it able to remove all symlinks instead? cargo should handle them autimatically.

@michel-slm
Copy link
Contributor Author

@oech3 cargo handles symlinks just fine, I've been sending similar fixes to include license files for multiple projects that have a single git repo with multiple crates all with the same license as part of the Fedora Rust SIG.

Happy to entertain other suggestions, but as you notice, src/uucore/LICENSE is also a symlink - this is a common pattern, it's just that it got missed with newer crates.

@oech3
Copy link
Contributor

oech3 commented Mar 19, 2026

Those symlinks break .zip on Windows. Would you consider removing them instrad?
This is really probrematic for the case we want to build *.exe from zip.

See also #9489 (comment)

cargo workspace is able to add the license flag to inherit the parent package licensing infromation, this symlink PR is no longer neccesary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants