uucore: remove redundant setup_localization call in help template #10908
+0
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly I think that this line here is one of the biggest contributors to the flakiness in the valgrind GNU tests. When I look at the memory allocations when shuf is run, this line here is a duplicated call to setup_localization that doubles the amount of allocations for the loading of the fluent files and by removing it the time it takes to load valgrind reduces by 50%.
The best long term fix here would be to implement lazy loading for the translations to only load the translations when they're needed, but hopefully this will increase the stability of the GNU tests for now and should bring some major memory and performance benefits to every utility call.