Re-enable unused_qualifications lint#10571
Merged
sylvestre merged 11 commits intouutils:mainfrom Feb 3, 2026
Merged
Conversation
Currently tested in linux environment and wanted to test if this fails in CI
|
GNU testsuite comparison: |
Contributor
|
Some jobs are sad |
Contributor
Author
|
Hahahahahahaha mhmmm, I'll push a fix in a bit |
670b9a3 to
ad88105
Compare
|
GNU testsuite comparison: |
c5d25d4 to
a7a0347
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
651f901 to
40e53e4
Compare
xtqqczze
reviewed
Jan 30, 2026
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
Contributor
Looks like #10442 |
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
xtqqczze
reviewed
Jan 30, 2026
Contributor
|
Overall, the changes look fine to me, but since in some cases the qualification might have been added to improve readability, we should consider those instances carefully. |
e20765d to
4df9e71
Compare
4df9e71 to
ad00954
Compare
|
GNU testsuite comparison: |
Contributor
|
broke CI: |
Contributor
Author
|
Yes, apparently this PR was considered stale and was merged. I'll follow up a fix |
Contributor
|
@sylvestre Is it time to use a merge queue to prevent this kind of issue? |
Contributor
|
it isn't a big deal :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-activates the
unused_qualificationslint by setting it back towarnin the lint config:Motivation
unused_qualificationshad been commented out due to warnings inuucore. Those warnings have now been addressed, so we can restore the lint to catch future regressions.Testing
Notes
If CI reports platform-specific warnings or toolchain differences, I’ll follow up with fixes or adjust the lint scope as needed.