split: accept overflow in --number option like GNU#10520
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
split: accept overflow in --number option like GNU#10520naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Use parse_size_u64_max() instead of parse_size_u64() to clamp overflow values to u64::MAX, matching GNU split behavior. Fixes uutils#10389
naoNao89
force-pushed
the
fix-split-overflow-10389
branch
from
64ae96e to
e31d74f
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10389
where split rejected overflow values like 2^64. Now it matches GNU behavior by clamping to
u64::MAXinstead of erroring. Switched from parse_size_u64() to parse_size_u64_max() based on GNU's OVERFLOW_OK pattern. Added regression test to prevent future breakage.