numfmt: support empty delimiter to treat line as single field #10145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
|
needs to be rebased |
ChrisDryden
force-pushed
the
numfmt-unit-separator
branch
from
d15e40d to
eff153f
Compare
Collaborator
Author
|
Actually after the re-base the conflicts make this approach somewhat redundant and a better approach can be taken, I'm going to close this |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Around 20 of the failing GNU test cases are partially failing because they use an empty delimiter in the test case. GNU supports empty delimiters and this change adds logic to be able to parse the empty delimiter as an empty field. After this change it will be a smaller change to add the delimiter parsing