Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Jan 7, 2026

This PR takes the commit from the previously made PR #9011 from @Arcterus. We already had integration tests made for this exact scenario but the validation in the integration test was not correct.

The high level idea is that uutils was overriding the error instead of using |= and when that is fixed only a single error is printed, which matches the GNU behavior

@ChrisDryden ChrisDryden changed the title rm: fix error reporting for -r on Linux rm: fix error reporting for -r on Linux fixing #9011 Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@ChrisDryden ChrisDryden marked this pull request as ready for review January 7, 2026 21:46
@ChrisDryden ChrisDryden force-pushed the rm-error-reporting-fix branch from 167fa8a to 3aaa04f Compare January 9, 2026 17:26
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants