forked from MutinyWallet/mutiny-node
-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Periodic Keychain Compaction to Optimize VSS Sync #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EthanYuan
merged 14 commits into
utxostack:develop
from
EthanYuan:fix-keychain-size-issue-vss
Apr 22, 2025
Merged
Implement Periodic Keychain Compaction to Optimize VSS Sync #105
EthanYuan
merged 14 commits into
utxostack:develop
from
EthanYuan:fix-keychain-size-issue-vss
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2679e9d to
e99c765
Compare
6ec40dc to
15282c1
Compare
15282c1 to
4597b31
Compare
Flouse
reviewed
Apr 21, 2025
Flouse
approved these changes
Apr 21, 2025
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The persisted
bdk_wallet::ChangeSet(keychain) grows significantly over time, mainly due tolocal_chainhistory. This large size (more than 1 MB) hinders efficient synchronization with VSS.Solution:
This PR implements periodic keychain compaction within the
start_syncloop:KEYCHAIN_COMPACTION_SIZE_THRESHOLD_BYTES(256 KB):Walletinstance and performingOnChainWallet::full_scan(using Esplora, stop_gap=50).storage.restore_changes, overwriting the old keychain. (restore_changes attempts backup).Test
keychian compaction log(10700 Bytes just for test):
keychain backup: