fix: set_device_lock loop internal and update_lnd_snapshot being unwritable for a long time
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanYuan
force-pushed
the
fix-set-device-internal
branch
from
02f51c6 to
e3e5c71
Compare
EthanYuan
changed the title
update_lnd_snapshot being unwritable for a long time
EthanYuan
changed the title
update_lnd_snapshot being unwritable for a long timeset_device_lock loop internal and update_lnd_snapshot being unwritable for a long time
EthanYuan
force-pushed
the
fix-set-device-internal
branch
2 times, most recently
from
dbe7741 to
618d9db
Compare
EthanYuan
force-pushed
the
fix-set-device-internal
branch
from
618d9db to
e4dfdbc
Compare
1 task
Flouse
reviewed
Mar 21, 2025
Flouse
reviewed
Mar 21, 2025
EthanYuan
force-pushed
the
fix-set-device-internal
branch
from
3831af8 to
7fb85e7
Compare
EthanYuan
force-pushed
the
fix-set-device-internal
branch
from
50b43f7 to
2575ff4
Compare
Flouse
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issue
where
update_lnd_snapshotcould take too long and delay the nextset_device_lock, breaking the expected timing cycle. Now make LND snapshot update async-safe and non-blockingallow
update_lnd_snapshotto VSS when onlydevice_lockwriting is pending, avoidingupdate_lnd_snapshotbeing unwritable for a long time.local testsed