Backport abstract request/response with adapters #212

ChiragAgg5k · 2026-02-09T11:19:54Z

Backport 0.34.x HTTP adapter split: make Request/Response abstract and add FPM/Swoole adapters. Update docs/tests to use adapters.

coderabbitai · 2026-02-09T11:20:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch backport-0.34-adapters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR backports the 0.34.x HTTP adapter split by making Utopia\Request and Utopia\Response abstract and introducing concrete adapters for FPM and Swoole, then updating docs/tests to use the new adapter classes.

Changes:

Make core Request/Response abstract and move environment-specific IO to adapters.
Add Utopia\Adapter\FPM\* and Utopia\Adapter\Swoole\* Request/Response (and Server wrappers).
Update tests, README, and Getting Started guide to import adapter Request/Response classes.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/e2e/server.php	Switch e2e server bootstrap to use FPM adapter Request/Response imports.
tests/UtopiaRequestTest.php	Update test helper class to extend FPM adapter Request.
tests/ResponseTest.php	Update tests to instantiate FPM adapter Response instead of abstract base.
tests/RequestTest.php	Update tests to instantiate FPM adapter Request instead of abstract base.
tests/ModelTest.php	Update model tests to use FPM adapter Request/Response.
tests/HttpTest.php	Update HTTP tests to use FPM adapter Request/Response.
src/Response.php	Convert Response to abstract; extract IO primitives (write/end/status/header/cookie) into abstract methods.
src/Request.php	Convert Request to abstract; extract environment-specific accessors and input parsing into abstract methods; adjust size calculation formatting.
src/Adapter/Adapter.php	Introduce abstract adapter interface for server lifecycle hooks.
src/Adapter/FPM/Server.php	Add FPM server adapter wrapper that wires FPM Request/Response into callbacks/resources.
src/Adapter/FPM/Request.php	Add concrete Request implementation for PHP-FPM superglobals + php://input parsing.
src/Adapter/FPM/Response.php	Add concrete Response implementation for PHP-FPM output/headers/cookies.
src/Adapter/Swoole/Server.php	Add Swoole server adapter wrapper bridging Swoole request/response to Utopia adapters.
src/Adapter/Swoole/Request.php	Add concrete Request implementation backed by Swoole request object.
src/Adapter/Swoole/Response.php	Add concrete Response implementation backed by Swoole response object.
docs/Getting-Starting-Guide.md	Update Swoole examples to use adapter Request/Response namespaces.
README.md	Update usage examples to import FPM adapter Request/Response.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Adapter/Swoole/Server.php

Copilot · 2026-02-09T11:35:38Z

src/Http/Adapter/Swoole/Server.php

+{
+    protected SwooleServer $server;
+
+    public function __construct(string $host, ?string $port = null, array $settings = [])


$port is typed as ?string and passed to new SwooleServer($host, $port), but Swoole’s server constructor expects an integer port. This can lead to runtime type errors depending on the Swoole version/build. Prefer int $port = 80 (or ?int) and cast/validate before passing to Swoole.

Suggested change

public function __construct(string $host, ?string $port = null, array $settings = [])

public function __construct(string $host, int $port = 80, array $settings = [])

Copilot · 2026-02-09T11:35:38Z

src/Http/Adapter/Swoole/Response.php

+            domain: $options['domain'] ?? '',
+            secure: $options['secure'] ?? false,
+            httponly: $options['httponly'] ?? false,
+            samesite: $options['samesite'] ?? false,


sendCookie() passes samesite: $options['samesite'] ?? false. Swoole’s cookie API expects samesite to be a string (or null/empty), not a boolean; passing false can cause a TypeError. Use ''/null as the default and only pass valid SameSite strings.

Suggested change

samesite: $options['samesite'] ?? false,

samesite: isset($options['samesite']) && is_string($options['samesite']) ? $options['samesite'] : null,

Copilot · 2026-02-09T11:35:38Z

src/Http/Adapter/Swoole/Request.php

+     */
+    public function getReferer(string $default = ''): string
+    {
+        return $this->getHeader('referer', '');


getReferer() ignores the $default parameter and always falls back to an empty string. This breaks the method contract vs the abstract Request API and differs from the FPM adapter. Use $default as the fallback value.

Suggested change

return $this->getHeader('referer', '');

return $this->getHeader('referer', $default);

Copilot · 2026-02-09T11:35:39Z

src/Http/Adapter/Swoole/Request.php

+     */
+    public function getHeader(string $key, string $default = ''): string
+    {
+        return $this->swoole->header[$key] ?? $default;


getHeader() looks up $this->swoole->header[$key] without normalizing the key. Swoole header keys are typically lowercased; callers may pass mixed-case names (e.g. Content-Type) and get unexpected misses. Consider normalizing (strtolower) and/or delegating to generateHeaders() (which already lowercases keys).

Suggested change

return $this->swoole->header[$key] ?? $default;

if (isset($this->swoole->header[$key])) {

return $this->swoole->header[$key];

}

$normalizedKey = \strtolower($key);

return $this->swoole->header[$normalizedKey] ?? $default;

Copilot · 2026-02-09T11:35:39Z

src/Http/Adapter/Swoole/Response.php

+     */
+    protected function sendStatus(int $statusCode): void
+    {
+        $this->swoole->status((string) $statusCode);


sendStatus() passes (string) $statusCode into $this->swoole->status(...). Swoole’s status() expects an int status code; passing a string may throw a TypeError in newer versions. Pass the integer status code through unchanged.

Suggested change

$this->swoole->status((string) $statusCode);

$this->swoole->status($statusCode);

Copilot · 2026-02-09T11:35:39Z

src/Http/Adapter/Swoole/Response.php

+     */
+    public function sendHeader(string $key, mixed $value): void
+    {
+        $this->swoole->header($key, $value);


sendHeader() forwards $value directly to $this->swoole->header($key, $value), but in this codebase headers may be arrays (see FPM adapter + base Response handling). Swoole’s header() expects a string value per call; array values should be expanded into multiple header() calls (or joined appropriately) to avoid runtime errors.

Suggested change

$this->swoole->header($key, $value);

if (\is_array($value)) {

foreach ($value as $singleValue) {

if ($singleValue === null) {

continue;

}

$this->swoole->header($key, (string) $singleValue);

}

return;

}

if ($value !== null) {

$this->swoole->header($key, (string) $value);

}

Copilot · 2026-02-09T11:35:40Z

src/Http/Request.php

+                $headerStrings[] = $key . ': ' . $value;
+            }
+        }
+        return \mb_strlen(\implode("\n", $headerStrings), '8bit') + \mb_strlen(\file_get_contents('php://input'), '8bit');


Request::getSize() still reads the body from php://input, which is FPM-specific. For non-FPM adapters (e.g. Swoole) this will report incorrect request sizes (and may do unnecessary IO). Since getRawPayload() is now abstract, prefer using mb_strlen($this->getRawPayload(), '8bit') here (or let adapters override getSize()).

Suggested change

return \mb_strlen(\implode("\n", $headerStrings), '8bit') + \mb_strlen(\file_get_contents('php://input'), '8bit');

$rawPayload = (string) $this->getRawPayload();

return \mb_strlen(\implode("\n", $headerStrings), '8bit') + \mb_strlen($rawPayload, '8bit');

Copilot · 2026-02-09T11:35:40Z

src/Http/Response.php

-    {
-        echo $content;
-    }
+    abstract public function write(string $content): bool;


Response::write() now returns bool, but core code paths (e.g. chunked send loop and chunk()) do not check the return value. If adapters use false to signal “client disconnected / cannot write”, the framework will continue writing anyway. Either handle the false return (stop further writes + mark response as sent), or keep write() as void if it’s not meant to be acted upon.

Copilot · 2026-02-09T11:35:40Z

src/Http/Adapter/FPM/Request.php

+    }
+
+    /**
+     * Remvoe header


Typo in docblock: "Remvoe header" → "Remove header".

Suggested change

* Remvoe header

* Remove header

Backport abstract request/response with adapters

9b0f4fb

Adjust Swoole adapter for non-coroutine server

563d217

ChiragAgg5k force-pushed the backport-0.34-adapters branch from a8cd7b2 to 563d217 Compare February 9, 2026 11:24

loks0n requested a review from Copilot February 9, 2026 11:28

loks0n approved these changes Feb 9, 2026

View reviewed changes

Copilot started reviewing on behalf of loks0n February 9, 2026 11:29 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

ChiragAgg5k added 9 commits February 9, 2026 17:09

Add Files helper and static file loading

4d3d7a4

Align request adapters with 0.34.x

7a2ceab

rename

d386463

Downgrade doctrine/instantiator for PHP compatibility

c84561d

Update model error expectation for Http namespace

95ea856

add back setTrustedIpHeaders

6f9e28e

try fix issues

64bf7bb

chore: add ide helper

8e12530

closer to swoole

f6572e3

ChiragAgg5k merged commit 409a258 into 0.33.x Feb 11, 2026
5 checks passed

ChiragAgg5k deleted the backport-0.34-adapters branch February 11, 2026 06:33

	public function __construct(string $host, ?string $port = null, array $settings = [])
	public function __construct(string $host, int $port = 80, array $settings = [])

	samesite: $options['samesite'] ?? false,
	samesite: isset($options['samesite']) && is_string($options['samesite']) ? $options['samesite'] : null,

	return $this->getHeader('referer', '');
	return $this->getHeader('referer', $default);

-        return $this->swoole->header[$key] ?? $default;
+        if (isset($this->swoole->header[$key])) {
+            return $this->swoole->header[$key];
+        }
+        $normalizedKey = \strtolower($key);
+        return $this->swoole->header[$normalizedKey] ?? $default;

	$this->swoole->status((string) $statusCode);
	$this->swoole->status($statusCode);

-        $this->swoole->header($key, $value);
+        if (\is_array($value)) {
+            foreach ($value as $singleValue) {
+                if ($singleValue === null) {
+                    continue;
+                }
+                $this->swoole->header($key, (string) $singleValue);
+            }
+            return;
+        }
+        if ($value !== null) {
+            $this->swoole->header($key, (string) $value);
+        }

	return \mb_strlen(\implode("\n", $headerStrings), '8bit') + \mb_strlen(\file_get_contents('php://input'), '8bit');
	$rawPayload = (string) $this->getRawPayload();
	return \mb_strlen(\implode("\n", $headerStrings), '8bit') + \mb_strlen($rawPayload, '8bit');

Backport abstract request/response with adapters #212

Backport abstract request/response with adapters #212

Uh oh!

Conversation

ChiragAgg5k commented Feb 9, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants