Merged
Conversation
…dapters - Introduced abstract methods in the Adapter class to check support for multiple fulltext and identical indexes. - Updated the Database class to utilize these new methods during index validation. - Enhanced the Mongo and SQL adapters to implement the new support checks. - Modified the Index validator to validate multiple fulltext and identical indexes. - Added unit and e2e tests to ensure proper validation behavior for these new features.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… into feat-mongo-index-validation
- Implemented methods to check support for multiple fulltext indexes and identical indexes. - These methods delegate functionality to the underlying adapter, enhancing index validation capabilities.
…difications - Added functionality to store original indexes before any modifications in the updateAttribute method. - Updated index validation to use the preserved original indexes, ensuring accurate validation when altering attributes. - Improved tests to verify behavior when updating attributes with empty newKey, accounting for identical index support.
- Updated index names in tests to ensure uniqueness and avoid conflicts. - Added debug output for supportsIdenticalIndexes to aid in troubleshooting. - Cleaned up whitespace in the AttributeTests to improve code readability.
- Added a check for fulltext index support before executing assertions in the testMultipleFulltextIndexValidation method. - Ensured that tests do not perform assertions if fulltext indexing is not supported, improving test reliability.
abnegate
reviewed
Sep 26, 2025
…index-validation # Conflicts: # src/Database/Database.php # src/Database/Validator/Index.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.