Skip to content

Implement cursor paging in Mongo adapter with default batch size for … #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shimonewman merged 1 commit into from
Sep 15, 2025
Merged

Implement cursor paging in Mongo adapter with default batch size for … #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions src/Database/Adapter/Mongo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ class Mongo extends Adapter

protected Client $client;

/**
* Default batch size for cursor operations
*/
private const DEFAULT_BATCH_SIZE = 1000;

//protected ?int $timeout = null;

/**
Expand Down Expand Up @@ -1277,15 +1282,43 @@ public function getSequences(string $collection, array $documents): array
$filters['_tenant'] = $this->getTenantFilters($collection, $documentTenants);
}
try {
$results = $this->client->find($name, $filters, ['projection' => ['_uid' => 1, '_id' => 1]]);
// Use cursor paging for large result sets
$options = [
'projection' => ['_uid' => 1, '_id' => 1],
'batchSize' => self::DEFAULT_BATCH_SIZE
];

$response = $this->client->find($name, $filters, $options);
$results = $response->cursor->firstBatch ?? [];

// Process first batch
foreach ($results as $result) {
$sequences[$result->_uid] = (string)$result->_id;
}

// Get cursor ID for subsequent batches
$cursorId = $response->cursor->id ?? null;

// Continue fetching with getMore
while ($cursorId && $cursorId !== 0) {
$moreResponse = $this->client->getMore($cursorId, $name, self::DEFAULT_BATCH_SIZE);
$moreResults = $moreResponse->cursor->nextBatch ?? [];

if (empty($moreResults)) {
break;
}

foreach ($moreResults as $result) {
$sequences[$result->_uid] = (string)$result->_id;
}

// Update cursor ID for next iteration
$cursorId = $moreResponse->cursor->id ?? null;
}
} catch (MongoException $e) {
throw $this->processException($e);
}

foreach ($results->cursor->firstBatch as $result) {
$sequences[$result->_uid] = (string)$result->_id;
}

foreach ($documents as $document) {
if (isset($sequences[$document->getId()])) {
$document['$sequence'] = $sequences[$document->getId()];
Expand Down Expand Up @@ -1575,8 +1608,7 @@ public function find(Document $collection, array $queries = [], ?int $limit = 25

try {
// Use proper cursor iteration with reasonable batch size
$batchSize = 1000;
$options['batchSize'] = $batchSize;
$options['batchSize'] = self::DEFAULT_BATCH_SIZE;

$response = $this->client->find($name, $filters, $options);
$results = $response->cursor->firstBatch ?? [];
Expand All @@ -1597,7 +1629,7 @@ public function find(Document $collection, array $queries = [], ?int $limit = 25
break;
}

$moreResponse = $this->client->getMore($cursorId, $name, $batchSize);
$moreResponse = $this->client->getMore($cursorId, $name, self::DEFAULT_BATCH_SIZE);
$moreResults = $moreResponse->cursor->nextBatch ?? [];

if (empty($moreResults)) {
Expand Down