feat: bump appwrite/appwrite to 24.*#113
Open
premtsd-code wants to merge 1 commit into
Open
Conversation
The SDK's 24.0.0 release renamed several Project-prefixed enums (AuthMethod -> ProjectAuthMethodId, ServiceId -> ProjectServiceId, ProtocolId -> ProjectProtocolId, ProjectPolicy -> ProjectPolicyId) and 24.1.0 made BillingLimits fields nullable to match the server's sparse 'limits crossed' response. abuse doesn't use any of the renamed enums; it only imports Client, AppwriteException, ID, Query, Models\Row, Services\TablesDB, and Enums\TablesDBIndexType -- all unchanged in 24.x. Composer lock updated to 24.1.0. Bump unblocks downstream consumers like utopia-php/migration that need the 24.x SDK.
Greptile SummaryThis PR widens the
Confidence Score: 5/5Safe to merge — only the SDK version constraint and lock file are touched, and the one file that consumes the SDK uses no symbols that changed in 24.x. The change is a single-line constraint bump plus an updated lock file. The sole SDK consumer (TablesDB.php) imports only symbols that are stable across 23.x and 24.x, and the lock resolves cleanly to 24.1.0 without touching any other package. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "feat: bump appwrite/appwrite to 24.*" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
appwrite/appwritePHP SDK constraint from23.*to24.*so downstream consumers (e.g.utopia-php/migration) can pull in the 24.x SDK without dependency conflicts.What's safe about this bump
The SDK 24.0.0 release introduced breaking changes — renamed
Project-prefixed enums (AuthMethod→ProjectAuthMethodId,ServiceId→ProjectServiceId,ProtocolId→ProjectProtocolId,ProjectPolicy→ProjectPolicyId) — and 24.1.0 madeBillingLimitsinner fields nullable.Abuse doesn't use any of the renamed symbols. Confirmed imports across
src/:TablesDBIndexTypewas renamed back in 21.0.0 (IndexTypesplit) and is stable in both 23.x and 24.x. All other symbols are unchanged.Verification
composer update appwrite/appwrite -Wresolves cleanly; lock updated to 24.1.0php -l src/Abuse/Adapters/TimeLimit/Appwrite/TablesDB.phppassescomposer check(phpstan level max) reports No errors onsrc/Motivation
utopia-php/migrationis bumping to 24.* on itsadd-policies-migrationbranch (PR #186) to pick up the BillingLimits nullable fix (which was crashing project-level migrations) and the newProject::get()/Project::getPolicy()methods. Right now, cloud's composer tree can't resolve migration@24.* alongside abuse@1.3.0 because of this constraint. Bumping here unblocks the chain.