Conversation
Merged
There was a problem hiding this comment.
Pull request overview
This PR removes the CSS box model exercise (Exercise 3) from the CSS chapter, as the box model concepts will be covered in a new "CSS Layout" chapter (per issue #891).
Key changes:
- Removed Exercise 3 (発展) which covered box model properties like margin, padding, border, border-radius, and box-shadow
- Deleted associated sample code and image resources
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/1-trial-session/03-css/index.mdx |
Removed Exercise 3 and its answer section covering box model styling |
docs/1-trial-session/03-css/_samples/foo/index.html |
Deleted sample HTML file demonstrating box model properties |
docs/1-trial-session/03-css/rounded-box-with-shadow.png |
Deleted screenshot image used in the removed exercise |
The changes in this PR are clean and complete. All references to the box model exercise have been properly removed, including:
- The exercise description and answer
- The sample code directory (
_samples/foo) - The associated image file
- The
ViewSourcecomponent reference
No orphaned references remain, and the chapter now ends cleanly after Exercise 2. The removal aligns well with the stated goal of moving box model content to a dedicated layout chapter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#891 により、「CSS によるレイアウト」の章でボックスモデル周辺の知識を説明するようになるため、「CSS」の章からはボックスモデルに触れる演習問題を削除