programmatic uses of doImport forgot to clear lookup caches afterwards. Fixes #2694#2695
Merged
DavyLandman merged 1 commit intomainfrom Mar 8, 2026
Merged
programmatic uses of doImport forgot to clear lookup caches afterwards. Fixes #2694#2695DavyLandman merged 1 commit intomainfrom
DavyLandman merged 1 commit intomainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6680 6678 -2
=======================================
Files 795 795
Lines 65904 65905 +1
Branches 9881 9881
=======================================
- Hits 30711 30710 -1
- Misses 32806 32812 +6
+ Partials 2387 2383 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This fixes #2694 which was caused by a cached version of the
conditionalconstructor which was created while loading an incomplete modulelang::rascal::grammar::definition::Symbols.importcommand on the REPL, all the caches are cleared and the new overloads are found.mvncommand or a normaljava -jar, thendoImportis called from the commandline parser code and this top-level function did not clear the intermediate caches.This fixes this urgent issue by calling
heap.clearLookupChaches();whendoImportis done.