Skip to content

Update CONTRIBUTING.md #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XxB1a wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update CONTRIBUTING.md #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ Thank you so much!
```bash
$ bundle exec jekyll serve --watch JEKYLL_ENV=development --config _config.dev.yml
```
7. Open http://localhost:4000/ in your browser to view
8. Pages can be edited by finding their name.html in the pages directory
9. Page parts (templates) can be edited by going to _includes or _layouts and editing the html
10. Fork the repo and commit your changes then create a pull request
7. Open http://localhost:4000/ in your browser to view.
8. Pages can be edited by finding their name.html in the pages directory.
9. Page parts (templates) can be edited by going to _includes or _layouts and editing the HTML.
10. Fork the repo and commit your changes then create a pull request.
11. Test the things.
Make sure the expected things are done. Make sure the rest of the page works.
11. Open a pull request. [And here's what that means.](https://help.github.com/articles/about-pull-requests/) Don't forget to compare your fork and USACS, so
Expand All @@ -32,7 +32,7 @@ This is how many open-source communities work. So this will give you practice.

**But why do they do this?**

Open source communities do this to allow a measure of control over the code theyhave.
Open source communities do this to allow a measure of control over the code they have.
By forcing the PR process, somebody who knows what's going on can test the code
and approve of the style and intent.

Expand All @@ -42,7 +42,7 @@ and approve of the style and intent.
- @hemangandhi
- The rest of USACS!
- [The GitHub flow.](https://guides.github.com/introduction/flow/)
- [What commiting etc. means.](https://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository)
- [What committing etc. means.](https://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository)
- [This is what pushing means.](https://help.github.com/articles/pushing-to-a-remote/)
- [This is what merging, branching, etc. is about.](https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging)

Expand Down