7.2: Fix parsing ip addr with peer information#2544
7.2: Fix parsing ip addr with peer information#2544ap-wtioit wants to merge 1 commit intounraid:7.2from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @ap-wtioit I have created a pr on the 7.3 branch as this will be a 7.3 fix. Thanks for your submission. Please feel free to close this pr. |
|
It looks like the regex will only cater for ipv4, Can you test the follow version to see if that still works for IPv4, are you able to test with IPv6? |
|
Merged your changes along with some mods - see #2555 |
|
The code now merged in #2555 looks good on our system (could restart sshd and nginx with the interface present and the file patched), unfortunately we don't have IPv6 so i cannot test that. but the regex looks good to me. Thanks for the fix. |
When adding tun0 to listening interfaces in settings. Unraid 7+ tries to parse:
ip addr show scope global primary -deprecated dev tun0and gets
10.9.8.66 peer 10.9.8.65/32 scope global tun0as the "IP" of the interface. This then proceeds to break sshd and nginx config for unraid.With this fix the peer information is removed and only the interfaces IP (in the example 10.9.8.66) is kept.
Info @wt-io-it