feat(onboarding): route plugin installs through ca.unraid.net/dl proxy#2000
Open
Squidly271 wants to merge 1 commit intomainfrom
Open
feat(onboarding): route plugin installs through ca.unraid.net/dl proxy#2000Squidly271 wants to merge 1 commit intomainfrom
Squidly271 wants to merge 1 commit intomainfrom
Conversation
Prefix the recommended plugin install URLs in the onboarding flow with https://ca.unraid.net/dl/ so installs go through the Community Applications download proxy instead of hitting raw.githubusercontent.com directly. Updates the URLs in both OnboardingPluginsStep.vue and the matching pluginMap in OnboardingSummaryStep.vue, plus the corresponding test expectation. The trailing .plg filename is preserved, so installed-plugin detection (which compares basenames against /boot/config/plugins) is unaffected.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
=======================================
Coverage 52.57% 52.57%
=======================================
Files 1033 1033
Lines 71659 71659
Branches 8176 8171 -5
=======================================
+ Hits 37673 37675 +2
+ Misses 33860 33858 -2
Partials 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://ca.unraid.net/dl/so installs go through the Community Applications download proxy instead of hittingraw.githubusercontent.comdirectly.OnboardingPluginsStep.vueand the parallelpluginMapinOnboardingSummaryStep.vue(the latter is what's actually passed to theinstallPluginmutation).OnboardingSummaryStep.test.ts.Why
Routing through
ca.unraid.net/dl/lets the install traffic go through the same download proxy CA uses, rather than each user pulling the.plgstraight from GitHub.Notes for reviewers
.plgfilename is preserved at the end of every URL, so the existing installed-plugin detection logic (which compares basenames against the contents of/boot/config/plugins) is unaffected. Tailscale'stailscale-preview.plgalias still works.validateInstallUrl(api/src/unraid-api/graph/resolvers/unraid-plugins/unraid-plugins.service.ts) only requires an http/https URL whose pathname ends in.plg, so the prefixed form passes validation.pnpm installfails on macOS for an unrelated native module (@unraid/libvirtnode-gyp build). The change itself is mechanical (string-only edits with a matching test update). Would appreciate a CI run to confirm.Test plan
pnpm test,pnpm lint,pnpm type-check)/boot/config/pluginsSummary by CodeRabbit
Release Notes