fix: OpenAPI Converter was not parsing examples for request parameters#88
Open
shane-rand wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…es on json_schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the parsing of OpenAPI Specifications to include
exampleorexamples. Previously, they were being silently dropped. https://spec.openapis.org/oas/v3.0.3#fixed-fields-9Fixes some Type Checking/Linting type errors
Summary by cubic
Preserves OpenAPI examples by parsing both
exampleandexamples, resolving$refs, and wiring them into JSON Schemaexamplesfor parameters, request bodies, and responses. Also tightens typing and adds tests to prevent regressions.requestBodymedia types (OAS3), and responses (media type and schema-level).$refinsideexamples; use inlinevalueonly and ignoreexternalValue.Literal/cast,getattr) and add tests for parameter, body, and response examples.Written for commit 15878ea. Summary will update on new commits.