fix: Respect <base> tag for relative link resolution in html2text (#1680)#1721
Merged
unclecode merged 1 commit intounclecode:developfrom Feb 1, 2026
Merged
Conversation
Fixes unclecode#1680 The HTML2Text class was ignoring the <base> tag, causing relative links to be resolved against the page URL instead of the base URL specified in the <base href="..."> attribute. Added <base> tag handling in both HTML2Text and CustomHTML2Text to update self.baseurl when the tag is encountered, ensuring proper link resolution according to HTML standards. Co-Authored-By: Claude <noreply@anthropic.com>
a3355fa to
2016d66
Compare
Owner
|
Merged into develop — thanks for the fix. We also added a complementary change to extract the |
This was referenced Feb 1, 2026
unclecode
added a commit
that referenced
this pull request
Feb 1, 2026
- PR #1714: Replace tf-playwright-stealth with playwright-stealth - PR #1721: Respect <base> tag in html2text for relative links - PR #1719: Include GoogleSearchCrawler script.js in package data - PR #1717: Allow local embeddings by removing OpenAI fallback - Fix: Extract <base href> from raw HTML before head gets stripped - Close duplicates: #1703, #1698, #1697, #1710, #1720 - Update CONTRIBUTORS.md and PR-TODOLIST.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Fixes #1680
Details
The HTML2Text class was ignoring the
<base>tag, causing relative linksto be resolved against the initial page URL instead of the base URL
specified in the HTML document.
According to HTML standards, the
<base>element specifies the base URLfor all relative URLs in a document. This is commonly used in:
Changes
<base>tag detection and baseurl updateExample
Before:
https://example.com/index.php/page.html<base href="https://example.com/">files/document.pdfhttps://example.com/index.php/files/document.pdf❌After:
https://example.com/files/document.pdf✅Test plan
🤖 Generated with Claude Code