Skip to content

Conversation

@meowwwls
Copy link

Ref. #21

Hi, @una! CSSGram is one of my favorite things out there, so I thought β€” having never really used filters or contributed to OS in a meaningful way β€” trying to contribute here would be a great experience. I'm new to this whole process, so hopefully I did everything right.

Snapshot from the test page

@mixin stinson($filters...) {
@include filter-base;
filter: sepia(.2) hue-rotate(-2deg) contrast(.9) brightness(1.05) $filters;
&::before {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D Please add a line space before the pseudo elements!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! Added now. :)

@una
Copy link
Owner

una commented Nov 3, 2016

Hey! Thanks for this, also just letting you know its a repeat of #250 and #251 -- going to give those precedence because they came first

@meowwwls
Copy link
Author

meowwwls commented Nov 3, 2016

Sorry about that! I should have looked before I submitted. :) Thanks for being so nice about it!

@meowwwls meowwwls closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants