Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4097 +/- ##
==========================================
+ Coverage 46.67% 46.83% +0.16%
==========================================
Files 136 136
Lines 29207 29297 +90
==========================================
+ Hits 13633 13722 +89
- Misses 15574 15575 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b2e456 to
a039485
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
Couple of concerns before I continue reviewing. The auto converter seems to be not getting the formatting quite correct
8a1d45e to
e1feefb
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
A couple of comments from this batch of the review... 248/312 viewed 😆
We should probably make some issues/papercuts about enabling ruff rules for docstrings now that they will be in a somewhat sensible format.
A lot of the docstrings are empty... this could also be a recurring papercut where each sprint someone checks the docstrings of say 5 files
|
|
||
|
|
||
| Parameters | ||
| ---------- | ||
| output : | ||
|
|
||
| tf_radial_dim : | ||
|
|
||
| tf_vertical_dim : | ||
|
|
There was a problem hiding this comment.
We need to make an issue to fill these empty parameter sections in... sounds papercutty
timothy-nunn
left a comment
There was a problem hiding this comment.
I haven't raised every single instance of :references:, some more will exist.
Some weird misalignments too.
That all the files currently checked.
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
Description
Closes #3834
Closes #1532
Closes #3844
possibly also #2936
This
Most of the docs changes were done automatically by the
pymentpackage with some manual fixes afterwards.This adds a few docs dependencies too.
Sorry its so long...
Checklist
I confirm that I have completed the following checks: