Standardise constraint residual/normalised residual calculations#4066
Merged
Standardise constraint residual/normalised residual calculations#4066
Conversation
timothy-nunn
force-pushed
the
standardise-constraints
branch
from
b38e1f1 to
aa68eee
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
+ Coverage 46.83% 46.86% +0.02%
==========================================
Files 136 136
Lines 29297 29228 -69
==========================================
- Hits 13722 13698 -24
+ Misses 15575 15530 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
force-pushed
the
standardise-constraints
branch
from
aa68eee to
6fb416c
Compare
Collaborator
|
Have tested and looked at, it seems reasonable. All values are now accurate and negative for all correct (passing) constraints |
je-cook
approved these changes
Feb 18, 2026
timothy-nunn
force-pushed
the
standardise-constraints
branch
from
6fb416c to
3034787
Compare
je-cook
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardises how we calculate normalised residuals and errors for constraints for our three types of constraints:
geq,eq,leq