FIx useMap type parameters to set value type as well#337
Open
BLucky-gh wants to merge 1 commit intouidotdev:mainfrom
Open
FIx useMap type parameters to set value type as well#337BLucky-gh wants to merge 1 commit intouidotdev:mainfrom
useMap type parameters to set value type as well#337BLucky-gh wants to merge 1 commit intouidotdev:mainfrom
Conversation
|
Came here to do this, seems like a pretty big oversight for complete typescript compatibility 😄 |
Author
|
Yeah the typescript types were handwritten after the fact by someone else in a pull request, so there can be problems like that in some places because of that. We ended up copying the hook into our own codebase with correct types in our project because of the delay in upstreaming it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
useMapseems to have been copy-pasted fromuseSetand its type signature does not allow setting map value type, and the initialValues type is straight up incorrect.This adds an extra type parameter for the value type, and makes the initialValues type match the type of the map constructor type