Open
Conversation
Owner
|
Thanks for your changes. Could you please maybe separate them into one commit per one PR? Each of your commits has its own functionality/meaning so it would be helpful to be able to discuss those in separate discussion threads. Thanks! |
Author
|
I checked out and could not find how to to so sir! |
…tla#14] This replaces calling std::vector::at() with direct operator[] access. It is somehow faster - maybe compiler-related optimization or lack of out-of-range checking when using operator[]. Out-of-range access is prevented thanks to validateCoordinates() method
Owner
|
@meysam81 Ideally each functionality/logical change should have its own PR, hence its own branch. Reviewing and discussion will be more effective and well arranged. |
uestla
force-pushed
the
master
branch
4 times, most recently
from
4e5e867 to
00445f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check it out if you like!