Skip to content

2.06 - Fixed problem with Json parsing. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsd-raul wants to merge 1 commit into
base: 2.06_Detect_Invalid_Location
Choose a base branch
from
Open

2.06 - Fixed problem with Json parsing. #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions app/src/main/java/com/example/android/sunshine/app/sync/SunshineSyncAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@
import java.util.Vector;

public class SunshineSyncAdapter extends AbstractThreadedSyncAdapter {
public final String LOG_TAG = SunshineSyncAdapter.class.getSimpleName();
private final String LOG_TAG = SunshineSyncAdapter.class.getSimpleName();
// Interval at which to sync with the weather, in seconds.
// 60 seconds (1 minute) * 180 = 3 hours
public static final int SYNC_INTERVAL = 60 * 180;
public static final int SYNC_FLEXTIME = SYNC_INTERVAL/3;
private static final int SYNC_INTERVAL = 60 * 180;
private static final int SYNC_FLEXTIME = SYNC_INTERVAL/3;
private static final long DAY_IN_MILLIS = 1000 * 60 * 60 * 24;
private static final int WEATHER_NOTIFICATION_ID = 3004;

Expand All @@ -75,13 +75,13 @@ public class SunshineSyncAdapter extends AbstractThreadedSyncAdapter {
@IntDef({LOCATION_STATUS_OK, LOCATION_STATUS_SERVER_DOWN, LOCATION_STATUS_SERVER_INVALID, LOCATION_STATUS_UNKNOWN, LOCATION_STATUS_INVALID})
public @interface LocationStatus {}

public static final int LOCATION_STATUS_OK = 0;
static final int LOCATION_STATUS_OK = 0;
public static final int LOCATION_STATUS_SERVER_DOWN = 1;
public static final int LOCATION_STATUS_SERVER_INVALID = 2;
public static final int LOCATION_STATUS_UNKNOWN = 3;
public static final int LOCATION_STATUS_INVALID = 4;

public SunshineSyncAdapter(Context context, boolean autoInitialize) {
SunshineSyncAdapter(Context context, boolean autoInitialize) {
super(context, autoInitialize);
}

Expand All @@ -96,7 +96,7 @@ public void onPerformSync(Account account, Bundle extras, String authority, Cont
BufferedReader reader = null;

// Will contain the raw JSON response as a string.
String forecastJsonStr = null;
String forecastJsonStr;

String format = "json";
String units = "metric";
Expand Down Expand Up @@ -130,14 +130,24 @@ public void onPerformSync(Account account, Bundle extras, String authority, Cont
urlConnection.connect();

// Read the input stream into a String
InputStream inputStream = urlConnection.getInputStream();
StringBuffer buffer = new StringBuffer();
InputStream inputStream;
try {
inputStream = urlConnection.getInputStream();
}catch (IOException e) {
inputStream = urlConnection.getErrorStream();
}

if (inputStream == null) {
// Nothing to do.
Log.e(LOG_TAG, "Error ");
// If the code didn't successfully get the weather data, there's no point in attempting
// to parse it.
setLocationStatus(getContext(), LOCATION_STATUS_SERVER_DOWN);
return;
}

reader = new BufferedReader(new InputStreamReader(inputStream));

StringBuffer buffer = new StringBuffer();
String line;
while ((line = reader.readLine()) != null) {
// Since it's JSON, adding a newline isn't necessary (it won't affect parsing)
Expand Down Expand Up @@ -174,7 +184,6 @@ public void onPerformSync(Account account, Bundle extras, String authority, Cont
}
}
}
return;
}

/**
Expand Down Expand Up @@ -253,7 +262,7 @@ private void getWeatherDataFromJson(String forecastJsonStr,
long locationId = addLocation(locationSetting, cityName, cityLatitude, cityLongitude);

// Insert the new weather information into the database
Vector<ContentValues> cVVector = new Vector<ContentValues>(weatherArray.length());
Vector<ContentValues> cVVector = new Vector<>(weatherArray.length());

// OWM returns daily forecasts based upon the local time of the city that is being
// asked for, which means that we need to know the GMT offset to translate this data
Expand Down Expand Up @@ -326,7 +335,6 @@ private void getWeatherDataFromJson(String forecastJsonStr,
cVVector.add(weatherValues);
}

int inserted = 0;
// add to database
if ( cVVector.size() > 0 ) {
ContentValues[] cvArray = new ContentValues[cVVector.size()];
Expand Down Expand Up @@ -372,7 +380,7 @@ private void notifyWeather() {
// we'll query our contentProvider, as always
Cursor cursor = context.getContentResolver().query(weatherUri, NOTIFY_WEATHER_PROJECTION, null, null, null);

if (cursor.moveToFirst()) {
if (cursor != null && cursor.moveToFirst()) {
int weatherId = cursor.getInt(INDEX_WEATHER_ID);
double high = cursor.getDouble(INDEX_MAX_TEMP);
double low = cursor.getDouble(INDEX_MIN_TEMP);
Expand Down Expand Up @@ -427,7 +435,9 @@ private void notifyWeather() {
editor.putLong(lastNotificationKey, System.currentTimeMillis());
editor.commit();
}
cursor.close();
if(cursor != null) {
cursor.close();
}
}
}
}
Expand All @@ -441,7 +451,7 @@ private void notifyWeather() {
* @param lon the longitude of the city
* @return the row ID of the added location.
*/
long addLocation(String locationSetting, String cityName, double lat, double lon) {
private long addLocation(String locationSetting, String cityName, double lat, double lon) {
long locationId;

// First, check if the location with this city name exists in the db
Expand All @@ -452,9 +462,10 @@ long addLocation(String locationSetting, String cityName, double lat, double lon
new String[]{locationSetting},
null);

if (locationCursor.moveToFirst()) {
if (locationCursor != null && locationCursor.moveToFirst()) {
int locationIdIndex = locationCursor.getColumnIndex(WeatherContract.LocationEntry._ID);
locationId = locationCursor.getLong(locationIdIndex);
locationCursor.close();
} else {
// Now that the content provider is set up, inserting rows of data is pretty simple.
// First create a ContentValues object to hold the data you want to insert.
Expand All @@ -477,15 +488,14 @@ long addLocation(String locationSetting, String cityName, double lat, double lon
locationId = ContentUris.parseId(insertedUri);
}

locationCursor.close();
// Wait, that worked? Yes!
return locationId;
}

/**
* Helper method to schedule the sync adapter periodic execution
*/
public static void configurePeriodicSync(Context context, int syncInterval, int flexTime) {
private static void configurePeriodicSync(Context context, int syncInterval, int flexTime) {
Account account = getSyncAccount(context);
String authority = context.getString(R.string.content_authority);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
Expand Down Expand Up @@ -521,7 +531,7 @@ public static void syncImmediately(Context context) {
* @param context The context used to access the account service
* @return a fake account.
*/
public static Account getSyncAccount(Context context) {
private static Account getSyncAccount(Context context) {
// Get an instance of the Android account manager
AccountManager accountManager =
(AccountManager) context.getSystemService(Context.ACCOUNT_SERVICE);
Expand Down Expand Up @@ -585,4 +595,4 @@ static private void setLocationStatus(Context c, @LocationStatus int locationSta
spe.putInt(c.getString(R.string.pref_location_status_key), locationStatus);
spe.commit();
}
}
}