Type hinting paginated lists #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

garth74 wants to merge 3 commits into ucfopen:develop from garth74:type-hinting-paginated-lists

garth74 commented Jul 25, 2022

Changes

This pull request makes two changes:

Adds type hinting to PaginatedList so that elements used in for-loops, list comprehensions, etc. are typed (more info).
Adds negative indexing to PaginatedList.

Related

Supports efforts of #435 and fixes #305 without preventing negative indexing all together (i.e., #306).

garth74 added 3 commits

July 25, 2022 10:05


          Added type hinting and negative indexing to PaginatedList

24f672b


          Updates test_paginated_list.py

27c2fae


          formatting

500f395

garth74 requested review from Thetwam and jessemcbride as code owners

July 25, 2022 15:26

bennettscience closed this

bennettscience mentioned this pull request

Issue/539 typed paginated list #656

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet