Open
Conversation
neil-tan
requested changes
Aug 28, 2020
Member
neil-tan
left a comment
There was a problem hiding this comment.
Thanks for the work!
One minor change requested in the main() for readability.
Though, this is an example that's meant to be run on all devices. The inclusion of additional image samples might not fit on the tiniest devices. My recommendation is holding back this PR until tests have been conduced for cortex M0 devices.
| // create the input/output tensor | ||
| Tensor input_image = new RomTensor({1, 28, 28, 1}, flt, arr_input_image); | ||
| Tensor logits = new RamTensor({1, 10}, flt); | ||
| size_t num_samples = *(&ref_labels + 1) - ref_labels; |
Member
There was a problem hiding this comment.
A macro define or a const variable is a better idea here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo multiple inferences