Merged
Conversation
Member
|
Having the two packages is fine, but I would like you to pick another name for this one, as it is not an official wrapper around AASVG. The name should make that explicit by being different or at least adding another word to distinguish it. This is the same as for |
> Auto-generated release commit by GitHub Actions
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting
Convert ASCII art diagrams into SVG powered by aasvg-rs.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcludedPDFs or README images, if any, but not the LICENSEEdit: I haven't paid attention before, but after carefully searching, I find that there is another ASCII to SVG drawing package bob-draw in the universe. Although both this package and bob-draw are powered by Rust and WASM, their underlying implementations are different. You can refer to the relevant implementations for more details. aasvg is better at handling lines and also has a smaller size (~ 110 KB while bob-draw's wasm is ~330 KB). Hopefully this can serve as a supplement