Skip to content

Collect typing differences into list #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzema12 merged 3 commits into from
Mar 27, 2026
Merged

Collect typing differences into list #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d93677
Collect typing differences into list
krzema12 Mar 27, 2026
dfd08f6
Revert me
krzema12 Mar 27, 2026
1a343f7
Fix
krzema12 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions .github/workflows/test.main.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ private data class ActionCoords(
val pathToTypings: String,
)

private data class TypingDifference(
val action: ActionCoords,
val extraInputsInManifest: Set<String>,
val extraInputsInTypings: Set<String>,
val extraOutputsInManifest: Set<String>,
val extraOutputsInTypings: Set<String>,
)

private fun validateTypings(sha: String, baseRef: String?) {
val typingsSchema = JsonSchema.fromDefinition(
URI.create("https://raw.githubusercontent.com/typesafegithub/github-actions-typing/" +
Expand All @@ -140,6 +148,8 @@ private fun validateTypings(sha: String, baseRef: String?) {

var shouldFail = false

val typingDifferences = mutableListOf<TypingDifference>()

for (action in actions) {
println()
println("➡\uFE0F For https://github.com/${action.owner}/${action.name}/tree/${action.version}/${action.path ?: ""}")
Expand Down Expand Up @@ -181,18 +191,17 @@ private fun validateTypings(sha: String, baseRef: String?) {

if (typingsInputs != manifestInputs || typingsOutputs != manifestOutputs) {
println("\uD83D\uDD34 Something is wrong with the typings!")
(typingsInputs - manifestInputs).let {
if (it.isNotEmpty()) { println("Extra inputs in typings: $it") }
}
(manifestInputs - typingsInputs).let {
if (it.isNotEmpty()) { println("Extra inputs in manifest: $it") }
}
(typingsOutputs - manifestOutputs).let {
if (it.isNotEmpty()) { println("Extra outputs in typings: $it") }
}
(manifestOutputs - typingsOutputs).let {
if (it.isNotEmpty()) { println("Extra outputs in manifest: $it") }
}

val difference = TypingDifference(
action = action,
extraInputsInManifest = manifestInputs - typingsInputs,
extraInputsInTypings = typingsInputs - manifestInputs,
extraOutputsInManifest = manifestOutputs - typingsOutputs,
extraOutputsInTypings = typingsOutputs - manifestOutputs
)
println(difference)

typingDifferences += difference
shouldFail = true
continue
}
Expand Down
2 changes: 0 additions & 2 deletions typings/actions/checkout/v6/action-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ inputs:
type: string
ssh-strict:
type: boolean
persist-credentials:
type: boolean
path:
type: string
clean:
Expand Down
2 changes: 2 additions & 0 deletions typings/actions/create-release/v1/action-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ inputs:
type: boolean
prerelease:
type: boolean
boogaa:
type: string
commitish:
type: string
owner:
Expand Down
Loading