Skip to content

Add opt-in setting for kind-projector underscore syntax #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-ivii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add opt-in setting for kind-projector underscore syntax #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions settings/src/main/scala/org/typelevel/sbt/TypelevelSettingsPlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ object TypelevelSettingsPlugin extends AutoPlugin {
lazy val tlJdkRelease =
settingKey[Option[Int]](
"JVM target version for the compiled bytecode, None results in default scalac and javac behavior (no compiler flag is added) (default: Some(8))")
lazy val tlKindProjectorUnderscores =
settingKey[Boolean]("Use _ instead of * for kind-projector (default: false)")
}

import autoImport._
Expand All @@ -46,6 +48,7 @@ object TypelevelSettingsPlugin extends AutoPlugin {
override def globalSettings = Seq(
tlFatalWarnings := false,
tlJdkRelease := Some(8),
tlKindProjectorUnderscores := false,
Def.derive(scalaVersion := crossScalaVersions.value.last, default = true)
)

Expand Down Expand Up @@ -193,16 +196,18 @@ object TypelevelSettingsPlugin extends AutoPlugin {
}
},
scalacOptions ++= {
val underscores = tlKindProjectorUnderscores.value || onlyScala3.value
scalaVersion.value match {
case V(V(3, minor, _, _)) =>
val kpFlag = if (minor >= 5) "-Xkind-projector" else "-Ykind-projector"
if (onlyScala3.value)
if (underscores)
Seq(s"$kpFlag:underscores")
else
Seq("-language:implicitConversions", kpFlag)

case V(V(2, minor, _, _)) if minor >= 12 =>
Seq("-language:_", "-Xsource:3")
val kp = if (underscores) Seq("-P:kind-projector:underscore-placeholders") else Nil
Seq("-language:_", "-Xsource:3") ++ kp

case _ => Seq("-language:_")
}
Expand Down
Loading