Support fs2.io.readOutputStream on Scala Native#3714
Conversation
lolgab
force-pushed
the
native-readOutputStream
branch
from
4236fb3 to
f46cd49
Compare
| } | ||
| test("classloader") { | ||
| val size = readClassLoaderResource[IO]("fs2/io/foo", 8192).as(1L).compile.foldMonoid | ||
| val resourcePath = if (isNative) "/fs2/io/foo" else "fs2/io/foo" |
There was a problem hiding this comment.
This difference surprised me. Does the absolute path not work on the JVM?
There was a problem hiding this comment.
Haven't investigated, but I think it's a bug in Scala Native, but since it's test code I preferred to add a if here and eventually when gets fixed upstream you'll see a failing test and it's trivial to remove the if.
There was a problem hiding this comment.
when gets fixed upstream you'll see a failing test
Maybe! But also it could be that both are valid, in which case there wouldn't be a failed test.
There was a problem hiding this comment.
You're right. I just checked, and the leading / doesn't work on the JVM. So it's a bug :)
There was a problem hiding this comment.
Just opened a PR on Scala Native to fix the bug: scala-native/scala-native#4901
|
Unfortunately the tests are hitting timeout on Scala Native, there might be something wrong with the Scala Native implementation (?). Did you see this before @armanbilge? |
I don't think there is anything wrong per-se, I think it may just actually be timing out since it involves a very large stream and may be running a bit slowly in Scala Native. Does it pass locally if you increase the timeout? fs2/io/jvm-native/src/test/scala/fs2/io/IoPlatformSuite.scala Lines 223 to 226 in 3ec3a25 |
Seems to pass for me. So we just need to increase the timeout for CI. |
|
Thank you @armanbilge, increasing the timeout indeed did fix it! |
2 participants
No description provided.