Fix duplicate elements emitted by timeoutWith after timeout fires#3709
Open
ankitkumarrain wants to merge 4 commits intotypelevel:mainfrom
Open
Fix duplicate elements emitted by timeoutWith after timeout fires#3709ankitkumarrain wants to merge 4 commits intotypelevel:mainfrom
ankitkumarrain wants to merge 4 commits intotypelevel:mainfrom
Conversation
ankitkumarrain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this bug on running sbt test , this is a flaky bug.
In def Timeoutwith, the merge in timed buffers data chunks concurrently, and the timeout handler passes these buffered chunks to both the timeout function f and the normal go loop. Because of this, timeoutOnPullTo ,timeoutOnPullWithand, timeoutWith can emit duplicate elements after a timeout fires.
Changes made in stream.scala
I made a fix introducing skipStaleTimeouts which skips any further queued timeouts and resumes normal processing with the first data chunk. This will prevent duplicate emission in timeoutOnPullTo and timeoutOnPullWith.