Report resource acquisition errors in ScalaTest CatsResource#635
Merged
armanbilge merged 1 commit intotypelevel:series/1.xfrom Feb 21, 2025
Merged
Conversation
Member
Author
|
I think we can merge this and release a patch version prior to whatever we decide to do with #632. |
armanbilge
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634.
We could probably make the same kind of changes that were suggested in #608 and #609, but we didn't really come to a consensus on that, so I left it alone for now. If we want to move forward with #609 we can make changes to the ScalaTest implementation there as well.