Use Global EC for CatsResource#555
Open
bcarter97 wants to merge 2 commits intotypelevel:series/1.xfrom
Open
Conversation
bcarter97
commented
Mar 9, 2024
|
|
||
| trait CatsResourceIO[A] extends CatsResource[IO, A] with RuntimePlatform { this: FixtureAsyncTestSuite => | ||
|
|
||
| override implicit def executionContext: ExecutionContext = ExecutionContext.global |
Author
There was a problem hiding this comment.
Without this CatsResourceAllocationSpecs will fail
edef036 to
084f7ee
Compare
Author
|
After changing to use JS Global EC, it seems a bunch of imports aren't working (to do with the Scalatest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #300
Loosely based on https://github.com/scalatest/scalatest/blob/310197b73d61f832bdfc4f7c939dbfa689057c54/jvm/scalatest-test/src/test/scala/org/scalatest/BeforeAndAfterAllSpec.scala#L76