Make ScalaTest retrying effect generic#472
Open
bcarter97 wants to merge 2 commits intotypelevel:series/1.xfrom
Open
Make ScalaTest retrying effect generic#472bcarter97 wants to merge 2 commits intotypelevel:series/1.xfrom
bcarter97 wants to merge 2 commits intotypelevel:series/1.xfrom
Conversation
bcarter97
commented
Jun 29, 2023
- Closes Implement ScalaTest ioRetrying with a generic effect type #471
Author
|
Failing binary compatibility: So it's the naming - not sure whether to rename it After some testing I think having an ioRetrying in terms of fRetrying is fine: def foo[F[_]: Async, T](t: T): F[T] = Async[F].pure(t)
// resolves ioRetrying implicit
def eventuallyIO: IO[String] = {
eventually {
foo[IO, String]("hello")
}
}
// resolves fRetrying implicit
def eventuallyF[F[_]: Async]: F[String] = {
eventually {
foo[F, String]("hello")
}
} |
Author
|
@sh0hei I think you approved the last build, is it possible to approve again? |
Author
|
@sh0hei any chance you can run the build? Otherwise if this is deemed no longer necessary I can close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.