Skip to content

fix: pass proxy_url to aiohttp request in AsyncTwilioHttpClient#911

Open
lariossoler wants to merge 1 commit intotwilio:mainfrom
lariossoler:main
Open

fix: pass proxy_url to aiohttp request in AsyncTwilioHttpClient#911
lariossoler wants to merge 1 commit intotwilio:mainfrom
lariossoler:main

Conversation

@lariossoler
Copy link

Resolves #788

Hello!

This PR addresses the issue where AsyncTwilioHttpClient receives a proxy_url during initialization but ignores it when constructing the actual aiohttp request kwargs.

By injecting the proxy into kwargs, we restore the ability to use the async client behind corporate firewalls.

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

class AsyncTwilioHttpClient takes "proxy_url" parameter, but does not use it for anything.

1 participant