fix: pass proxy_url to aiohttp request in AsyncTwilioHttpClient#911
Open
lariossoler wants to merge 1 commit intotwilio:mainfrom
Open
fix: pass proxy_url to aiohttp request in AsyncTwilioHttpClient#911lariossoler wants to merge 1 commit intotwilio:mainfrom
lariossoler wants to merge 1 commit intotwilio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #788
Hello!
This PR addresses the issue where
AsyncTwilioHttpClientreceives aproxy_urlduring initialization but ignores it when constructing the actual aiohttp request kwargs.By injecting the proxy into kwargs, we restore the ability to use the async client behind corporate firewalls.
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.