fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment()#823
Open
bhaskar16 wants to merge 2 commits intotwilio:mainfrom
Open
fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment()#823bhaskar16 wants to merge 2 commits intotwilio:mainfrom
bhaskar16 wants to merge 2 commits intotwilio:mainfrom
Conversation
Bazzooka1972
approved these changes
Jan 20, 2025
Author
|
@Bazzooka1972 Could you tell me how to ensure that the tests run? I would like to merge this when I can. |
6533f63 to
78a8ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #601
Closes #601
This PR changes the RequestValidator's updatePort() method to use the raw implementations for Path, Query and Fragment which helps in better sanitisation of urls.
Checklist